Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map to basesections reorganized 2 #427

Merged
merged 40 commits into from
Sep 13, 2024
Merged

Map to basesections reorganized 2 #427

merged 40 commits into from
Sep 13, 2024

Conversation

RubelMozumder
Copy link
Collaborator

No description provided.

@lukaspie lukaspie mentioned this pull request Sep 11, 2024
Closed
@RubelMozumder RubelMozumder force-pushed the map-to-basesections-reorganized_2 branch from 685d374 to ccd81ef Compare September 11, 2024 10:29
@RubelMozumder RubelMozumder marked this pull request as ready for review September 11, 2024 10:30
sanbrock
sanbrock reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can go with this, or we may want to activate the renaming function. See comments

lukaspie and others added 24 commits September 12, 2024 09:41
@lukaspie @RubelMozumder
import basesections
e94b706
@lukaspie @RubelMozumder
initiate base section map
35b1356
@lukaspie @RubelMozumder
implement mapping in __to_section
b532f64
@lukaspie @RubelMozumder
type hinting
7bd19b3
@lukaspie @RubelMozumder
name testing
af715bf
@lukaspie @RubelMozumder
create own basesections with mapping
6fb0cd4
@lukaspie @RubelMozumder
dynamically create class that inherits from base section
deb79bd
@lukaspie @RubelMozumder
use base section mapping function
7a23859
@lukaspie @RubelMozumder
add base section directly
86d3840
@RubelMozumder
rename nexus to nomad.
76ac1aa
@RubelMozumder
rename nexus to nomad.
4ed032b
@lukaspie @RubelMozumder
harmonize collaborative work, functionality to get the correct defini…
b1deab7 
…tions url
@lukaspie @RubelMozumder
rename file with remote definitions url
1b5e669
@lukaspie @RubelMozumder
add .txt to MANIFEST
de4aa07
@lukaspie @RubelMozumder
test for definitions url retrieval
bb378ec
@lukaspie @RubelMozumder
remove unneeded function
4f2efaa
@RubelMozumder
Fix error Parsing NeXus file: Error from resolve_variadic_name function.
3fb908e
@RubelMozumder
Test effort to fix error in parsing nexus file.
579795e
@lukaspie @RubelMozumder
revert changes to parser
7c3e024
@lukaspie @RubelMozumder
revert changes to parser
b850b8f
@RubelMozumder
Nomad BaseSeection implemented properly.
341284c
@RubelMozumder
Attempt: Add normalize function.
ec3a8a2
@lukaspie @RubelMozumder
linting fix
fd71d09
@lukaspie @RubelMozumder
reorganize, dont use new classes
f1ce2e8
@RubelMozumder RubelMozumder force-pushed the map-to-basesections-reorganized_2 branch from 9932fc0 to 704bf78 Compare September 12, 2024 07:52
sanbrock
sanbrock approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubelMozumder RubelMozumder merged commit d32cb0e into master Sep 13, 2024
12 checks passed
@RubelMozumder RubelMozumder deleted the map-to-basesections-reorganized_2 branch September 27, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbrock sanbrock sanbrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RubelMozumder @sanbrock @lukaspie @GinzburgLev